apparently the prompts given to input() go to stderr when python isn't running in tty, maybe this fixture would be helpful generally #10
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcientist
changed the title
|
Thank you for the contribution. I would prefer to take a simpler approach for redirecting standard input than to use a custom fixture. The following approach does not cause prompts to go to stderr, and the user input is in the same format as other jmu_pytest_utils functions: class redirect_stdin:
"""Context manager that temporarily redirects standard input."""
def __init__(self, user_input):
self.user_input = user_input
def __enter__(self):
sys.stdin = StringIO(self.user_input)
def __exit__(self, exc_type, exc_val, exc_tb):
sys.stdin = sys.__stdin__Note: PEP8 would prefer the spelling You would use @weight(1)
def test_welcome(capsys):
"""Prompt is displayed."""
test_books_2 = [b for b in TEST_BOOKS_2_TEMPLATE]
with redirect_stdin("0\n"):
main(test_books_2)
out, _ = capsys.readouterr()
assert "Welcome to the Little Free Library!" in out, "Welcome message not displayed"
assert "Please enter the number for the action you wish to perform:" in out, "Action prompt not displayed"What do you think of this alternative to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in testing output, as in test_kiosk I needed to read the program's output. I was doing that with capsys, but apparently prompts given to python's
input()function won't be available in the stdout as captured in this way. We could instruct students to useprintspecifically to output their prompts, but that feels unnecessarily fragile.